December 09, 2022, 02:07:59 am

The Gang Garrison 2 Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

NOTICE: Due to a rise in bot activity, new posters need to be approved before posting.

Join the community Discord server!

Pages: [1]

Author Topic: The server-sent plugins approval process  (Read 1843 times)

ajf

  • (Ex-?)Developer and forum/web admin
  • *****
  • Karma: 7
  • Offline Offline
  • Posts: 3492
  • she's never quite as dead as you think
The server-sent plugins approval process
« on: July 27, 2014, 10:41:06 am »

For some reason, I decided to tell BassMakesPaste the full process I use for adding and updating server-sent plugins. Here it is:

The "process" as such is as follows:

  • I create the directory /Users/ajf/Projects/2011/Gang Garrison 2/Plugins/Approvals/YYYY-MM-DD Author - pluginname on my computer (and suffix (update) if it's an update)
  • I create the subdirectory v1 (approved) in that directory (if I don't approve it, I'll rename that to just v1 and create a v2 (approved) with the fixed version and so on)
  • The plugin zip is downloaded to v1 (approved) and extracted into its own subdirectory (if the zip was plugin.zip, a directory called plugin would be made)
  • If it's a new plugin, I'll look at the gml files in my favourite text editor. If it's an existing plugin, I use diff on the command line with the previous version and the new version to see what's changed.
  • If I'm happy with it, I copy the zip file to htdocs/pluginname.zip in the copy of the repository on my machine
  • I run my script (which is in the repository) like so: php md5.php htdocs/pluginname.zip - It'll rename the zip file so it has the MD5 hash in its name after an @, create a .md5 file, and update data.json. (If it's a new plugin, I need to edit data.json to add the author's name and the forum thread number)
  • I quickly check I didn't screw anything up with git status then add the changes to git with git add .
  • I commit the changes, usually with this format: git commit -m "Updated Author's 'pluginname'"
  • I push the changes to the repository on GitHub: git push
  • I ssh into the ganggarrison.com server and update the copy of the repository there (hence updating /plugins/): ssh ganggarrison.com "cd /var/www/plugins && git pull"

And that's it. I'm not sure why I bothered going into such detail, but that's the actual process.
Logged
aka Andrea.

did you know that spinning stars work like this???

I've seen things you people wouldn't believe. execute_strings on fire off the shoulder of Overmars. I watched object-beams glitter in the dark near the room_goto_fix. All those moments will be lost in time, like tears...in...rain. Time to die.

Lorgan

  • Retired Randomizer Mod Developer
  • Resident Miku
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 3657
    • My own website
Re: The server-sent plugins approval process
« Reply #1 on: July 27, 2014, 11:24:14 am »

For some reason, I decided to tell BassMakesPaste the full process I use for adding and updating server-sent plugins. Here it is:
  • If it's a new plugin, I'll look at the gml files in my favourite text editor. If it's an existing plugin, I use diff on the command line with the previous version and the new version to see what's changed.
Lies!
Logged
Unfortunately, turning a section into a communist oppressive regime is not against the forum rules, so there is really nothing we can do.
Quote from: steam
21:08 - Hullusorsa: lorgan, when will you buy us the keys?
21:09 - Lorgan: i'm waiting for greece to collapse so the value of the euro drops
21:09 - Lorgan: not even joking

ajf

  • (Ex-?)Developer and forum/web admin
  • *****
  • Karma: 7
  • Offline Offline
  • Posts: 3492
  • she's never quite as dead as you think
Re: The server-sent plugins approval process
« Reply #2 on: July 27, 2014, 11:47:16 am »

Are you accusing me of not actually checking your plugins' updates?

Because I would never, ever do that, would I?
« Last Edit: July 27, 2014, 11:54:02 am by ajf »
Logged
aka Andrea.

did you know that spinning stars work like this???

I've seen things you people wouldn't believe. execute_strings on fire off the shoulder of Overmars. I watched object-beams glitter in the dark near the room_goto_fix. All those moments will be lost in time, like tears...in...rain. Time to die.

Phantom Brave

  • All Hail Classicwell
  • Moderator
  • *****
  • Karma: 70
  • Offline Offline
  • Posts: 12701
  • Another one --
Re: The server-sent plugins approval process
« Reply #3 on: December 21, 2014, 02:19:52 am »

Simplified version:

* Verify plugin is not malicious
* Upload to /var/www/plugins
* Run /var/www/plugins> php md5.php htdocs/pluginarchive.zip
* Update data.json if plugin is new
* Do git on the server
** Hope AJF/Medo don't get mad at you for doing things backwards
« Last Edit: December 21, 2014, 02:21:13 am by Phantom Brave »
Logged

http://steamcommunity.com/id/wareya/
ladies and gentlemen i would like to announce that the fact of the matter is up that the fact of the matter is a fact and it matters

ajf

  • (Ex-?)Developer and forum/web admin
  • *****
  • Karma: 7
  • Offline Offline
  • Posts: 3492
  • she's never quite as dead as you think
Re: The server-sent plugins approval process
« Reply #4 on: January 22, 2015, 08:09:42 am »

Simplified version:

* Verify plugin is not malicious
* Upload to /var/www/plugins
* Run /var/www/plugins> php md5.php htdocs/pluginarchive.zip
* Update data.json if plugin is new
* Do git on the server
** Hope AJF/Medo don't get mad at you for doing things backwards
I won't be mad, but make sure you use the correct author on your commits ;)
Logged
aka Andrea.

did you know that spinning stars work like this???

I've seen things you people wouldn't believe. execute_strings on fire off the shoulder of Overmars. I watched object-beams glitter in the dark near the room_goto_fix. All those moments will be lost in time, like tears...in...rain. Time to die.

Phantom Brave

  • All Hail Classicwell
  • Moderator
  • *****
  • Karma: 70
  • Offline Offline
  • Posts: 12701
  • Another one --
Re: The server-sent plugins approval process
« Reply #5 on: February 09, 2015, 06:12:13 am »

git amend
Logged

http://steamcommunity.com/id/wareya/
ladies and gentlemen i would like to announce that the fact of the matter is up that the fact of the matter is a fact and it matters
Pages: [1]
 

Page created in 0.08 seconds with 51 queries.