October 04, 2023, 03:12:43 pm

The Gang Garrison 2 Forum

Please login or register.

Login with username, password and session length
Advanced search  


NOTICE: Due to a rise in bot activity, new posters need to be approved before posting.

Join the community Discord server!

Pages: 1 [2]

Author Topic: Code standards (again)  (Read 25972 times)


  • (Ex-?)Developer and forum/web admin
  • *****
  • Karma: 7
  • Offline Offline
  • Posts: 3493
  • she's never quite as dead as you think
Re: Code standards (again)
« Reply #15 on: August 11, 2013, 04:39:50 pm »

I reviewed this now as part of the pull request and my take is that the coding guidelines as proposed here go a bit too far. Indentation and brace placement affect readablilty quite a lot, but do we really want to waste time fighting over where to place spaces in an expression? I say focus on the most important readability points and just cope with the rest instead of imploring new contributors to learn a larger set of rules. And I'd prefer to have people thinking about the code design than about some minor layout issue.
True, but we need common standards. Arctic made a pull request earlier which was unreadable.
did you know that spinning stars work like this???

I've seen things you people wouldn't believe. execute_strings on fire off the shoulder of Overmars. I watched object-beams glitter in the dark near the room_goto_fix. All those moments will be lost in time, like tears...in...rain. Time to die.
Pages: 1 [2]

Page created in 0.032 seconds with 35 queries.