Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Lorgan]

I didn't quite feel like reading that entire frankenstein plugin but I you list the killstreak texts 3 times in the main plugin and once in log plugin. /WHY/

Also I don't understand why you would want to sync killstreaks since they're so easy to keep track of clientsided.

Also you're attempting to send chat messages as host (which is dumb since you also want to put them in the killlog) and then you duplicated that code in the client part again...

[ZaSpai]

I didn't quite feel like reading that entire frankenstein plugin but I you list the killstreak texts 3 times in the main plugin and once in log plugin. /WHY/

Also I don't understand why you would want to sync killstreaks since they're so easy to keep track of clientsided.

Also you're attempting to send chat messages as host (which is dumb since you also want to put them in the killlog) and then you duplicated that code in the client part again...

It's all copied from whatever Cerapter and Rummy had before, I'll trim things off as I work out what works I suppose

Why is for the same reason as Cerapter, learning networking (also the RTD will come in eventually)

Probably gonna force everything to the kill log at the end of it (as for RTD effects I have no idea)

Long story short should the only things I should be doing be calling KS on the host under global.isHost section, and clients just send/receive the buffer?

[Lorgan]

Actually I think you guys broke this thing beyond repair. I'll take a look at the player end step:

Code: [Select]

        ksBuffer = buffer_create();
        write_ubyte(ksBuffer,ds_list_find_index(global.players,global.myself));
        PluginPacketSend(ksRTDPacket,ksBuffer);
        buffer_destroy(ksBuffer); What's the point of this? Both client and server do this too...
Also the if check above this code is reaaalllly fishy, I haven't checked but multiple clients will execute that code even when they didn't just die.

Code: [Select]

if global.isHost {
with(global.myself) {
currentStreak = stats[KILLS]
killStreak = 0;
var resetTimer;
resetTimer = 0;
}
}
} "If you're host, reset your own stats. everytime ANY player dies"

Then when you check if the killstreak increased, you send the player id thing again (the code in the first block i posted)
After that you do the same as above, if ANY player got a kill, check if the host can announce a killstreak

Then the whole killstreak text dealio which has no point. Then the chat thing, which looks broken since you're calling a user_event(4) outside the chatwindow object.
Then you put the killstreak in the killlog. (only as host)

Then you read all pluginpackets attempt sending stuff to chat and announcing stuff to the killlog again (as host). After that you basically send the id back to everyone as host (which includes your self in the latest version of gg2 if i'm not mistaking)

After that, stuff that happens as client:
try sending stuff to chat as a host (eeeyup)
put thing in killlog

Also the indentation looks horrible (in game maker at least)

[ZaSpai]

Maybe it's easier for me to understand what errors there are with what I have if I explain my intentions at the moment:

(click to show/hide)

argument0 and 1 are self explanatory as are the sprites

ignore the ds_map i thought I could be clever with data and somehow call a particular playerid value and match it with a KS counter key

creation for player as per what was given in the comment in-file. idk how to reference if it were in PlayerControl when talking about the Character associated (i.e. the player.object)

draw function is debug

Ok now to the bit of concern (which I tried to structure based on how space plugin does it, hence all the repeated code):

first endstep bit

I want a a packet to be sent to host under the following 2 conditions:
1. They gain a kill, and increase their killstreak locally (with only the host executing the killstreak shenanigans - as per host sent plugin, then the chat stuff) and writes killlog, which was not the intended action)
2. They die, and KS resets to 0 while other parameters update accordingly (locally with multiclienting, the stats didn't reset on the 'host' side when the 'client' died)
If the host had these events happen to them they just execute it. Did somehow make the host repeat itself due to the lower bit?
For the loopback function for 2.6.9, I didn't define it in PluginPacketSend as it caused a loop hang on the host side.

I want the packet to give more information about the current killStreak and kills to last death (since all it does right now is send player id) but is that allowed if I write more ubytes?

second bit checking global.isHost:

While host, receiving a packet from a(ny) client I meant for the client to tell the host whether changes in KS or death for THAT client has occurred then the streakcheck/chat bit executes (repeat if a client does it, since the killlog repeated itself last time I checked)

While client, same thing.

I don't really know how to call the killog up while client in the current format (I'm proposing just to copy the whole style that doEvent/sendEvent scripts do. The question remains why do I use SSP packets for this)

Again I probably should receive data about KS/kills to last death if ubyte reading is allowed etc

Everything else is not worked on atm

I'm using Notepad++ right now for setting out, I suppose a Gist paste and tab indent change might sort it out (if not I'll GML optimize later)

Cerpater's last attempt on it is here

If I were to push on through this, ahem, mess and get the RTD dice uses and effect number(s) active etc (I'd have to redefine effect[0] as no effect because ubytes won't accept noone or -1) can I also create a new buffer for that purpose specifically?

Also should I change the killstreak parts to just use global.SendBuffer (and take it on course to a non argument1 plugin with collateral script executions)?

[Lorgan]

the logical way to do this is:
Keep track of killstreaks on the host and just send a simple event with the pluginpackets when someone got a killstreak that needs to be put in the killlog.
The clients don't need to send anything, if I understand this correctly RTD is supposed to be triggered by the killstreaks right? That means that the client doesn't ever have to send anything to the server, only receive an event to add things to the killlog and maybe what effect a player got.

Again, it's better to start over (just keep that script to put things in the killlog) because none of the new code in that plugin works I think.

[ZaSpai]

The way Cerapter has RTD set is that the killstreak determines the 'power' of the effects of dice, of which a block may be added for each kill made (max 3). Should the taunt to roll bit be plugin packet buffered?

Re the KS section, alright.

[Lorgan]

If you want taunting to activate rtd, just trigger the diceroll on taunt.
If you want to bind the diceroll to a different key, make the client send a packet to the server everytime that key is pressed.

[ZaSpai]

Alright.

(The following is asking anyone else who cares about the plugin, not just Lorgan )

Now as I recall the original RTD spat out a message in chat whenever an effect or RTD death occurred, but I don't really want to clutter the existing kill log just for the purposes of RTD related messages (Player died while using RTD may be an exception), not to mention I'd like to have the SSP also function in non chat servers. Should I make a ghetto log just for RTD stuff, and if so where should it be placed? (Top left corner? Where chat normally is?)

Also is there significant desync with original RTD at all (everything's host managed right?)? All the hyper speed things aren't desync so much as horrible control of movement

[Lorgan]

The hyperspeed is somewhat desynced, if there is infinite jumping, that's a bit desynced and the broken spy thing.

I don't think there should be simultaneous dicerolls because that's what makes it a cluttered.
Did rtd ever use chat? Pretty sure it only used the servermessage thing.

[ZaSpai]

The hyperspeed is somewhat desynced, if there is infinite jumping, that's a bit desynced and the broken spy thing.

I don't think there should be simultaneous dicerolls because that's what makes it a cluttered.
Did rtd ever use chat? Pretty sure it only used the servermessage thing.

I'm gonna base the effects on Cerapter's choice so hyperspeed/infinijump/brokenteamswitch will be gone

Yeah I kinda don't want to stack rolls...

As for the message thing I'll have a quick check (maybe I'm used to seeing it on RM + RTD or something)

EDIT - trust Skele's server to have RTD + RM (tho Arctic did the relevant code thing I think)
I feel like I might add icons to the RTD log but it might get too cluttered then -_-"

[ZaSpai]

Ugh I hate double posts

I've got the kill log to sync the killstreak message but now it's looping the messages every step for both host and client (along with the annoying notice sound) until the milestone has been passed, code is as follows

(click to show/hide)

plugin.gml

Code: [Select]

//set argument0 and argument1 as necessary
globalvar ksRTDPacket, resourceFolder;
resourceFolder = argument0;
ksRTDPacket = argument1;

//define sprites
globalvar Streak3S, Streak6S, Streak9S, Streak12S, Streak15S, Streak20S, Streak25S, Streak30S;
    Streak3S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak3S.gmspr");
    Streak6S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak6S.gmspr");
    Streak9S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak9S.gmspr");
    Streak12S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak12S.gmspr");
    Streak15S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak15S.gmspr");
    Streak20S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak20S.gmspr");
    Streak25S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak25S.gmspr");
    Streak30S = sprite_add_sprite(resourceFolder+"/KSRTD/Streak30S.gmspr");
    sprite_set_offset(Streak3S,8,5);
    sprite_set_offset(Streak6S,8,5);
    sprite_set_offset(Streak9S,8,5);
    sprite_set_offset(Streak12S,8,5);
    sprite_set_offset(Streak15S,8,5);
    sprite_set_offset(Streak20S,8,5);
    sprite_set_offset(Streak25S,8,5);
    sprite_set_offset(Streak30S,8,5);

object_event_add(Character,ev_create,0,"
    currentStreak = player.stats[KILLS];
killStreak = 0;
");

/* Maybe I'll work something out with maxStreaks later
object_event_add(Player,ev_create,0,"
    tempStreak = 0;
maxStreak = 0;
");
*/

/* This is debug and should be commented out
object_event_add(Character,ev_draw,0,"
var xr, yr;
xr = round(x);
yr = round(y);
if(distance_to_point(mouse_x, mouse_y)<25) {
if cloak && team!=global.myself.team exit;
draw_set_alpha(1);
draw_set_halign(fa_center);
draw_set_valign(fa_bottom);
if(team==TEAM_RED) {
draw_set_color(c_red);
} else {
draw_set_color(c_blue);
}
draw_text(xr, yr+40, 'Current KS/Max KS/Total Kills: ' + string(killStreak) + '/' + string(player.maxStreak) + '/' + string(player.stats[KILLS]));
}
");
*/

/*
object_event_add(Character,ev_destroy,0,"
player.tempStreak = killStreak;
with (player) {
if !variable_local_exists('maxStreak') {
maxStreak = 0;
}
if tempStreak > maxStreak {
maxStreak = tempStreak;
}
}
");
*/

object_event_add(Character,ev_step,ev_step_normal,"
if (player.stats[KILLS] > currentStreak && player.stats[KILLS] - currentStreak != killStreak) {
killStreak = player.stats[KILLS] - currentStreak;
}
if (global.isHost) {
var KSSwitch;
KSSwitch = 0;
if (killStreak == 3 || killStreak == 6 || killStreak == 9 || killStreak == 12 ||
killStreak == 15 || killStreak == 20 || killStreak == 25 || killStreak == 30){
KSSwitch = 1;
var ksSend;
ksSend = buffer_create();
write_ubyte(ksSend,killStreak);
write_ubyte(ksSend,ds_list_find_index(global.players, player));
PluginPacketSend(ksRTDPacket,ksSend);
buffer_destroy(ksSend);
if KSSwitch = 1 {
var isMe;
isMe = (player == global.myself);
execute_file(resourceFolder + '/recordStreakInLog.gml',killStreak,player.team,player,isMe);
KSSwitch = 0;
}
}
    }
");

object_event_add(Player,ev_step,ev_step_begin,"
while(PluginPacketGetBuffer(ksRTDPacket) != -1) {
ksReceive = PluginPacketGetBuffer(ksRTDPacket);
streak = read_ubyte(ksReceive);
streakPlayer = ds_list_find_value(global.players, read_ubyte(ksReceive));
var isMe;
isMe = (streakPlayer == global.myself);
execute_file(resourceFolder + '/recordStreakInLog.gml',streak,streakPlayer.team,streakPlayer,isMe);
buffer_destroy(ksReceive);
PluginPacketPop(ksRTDPacket);
exit;
}       
");

recordStreakInLog.gml:

Code: [Select]

    // Record killstreak log
    // argument0: level of killstreak
    // argument1: The team
    // argument2: The player name
    // argument3: Am I involved?
        var message, sprite, icon, name, action;
        message = "";
        sprite = -1;
        icon = "";
        name = string_copy(argument2.name, 1, 20);
        action = "";
        if argument0==3 {
            message = "got a triple kill (3)!";
            icon = "kill3";
        }
        else if argument0==6 {
            message= "got a M-M-M-Monster kill (6)!";
            icon = "kill6";
        }
        else if argument0==9 {
            message = "got a ludicrous kill (9)!!";
            icon = "kill9";
        }
        else if argument0==12 {
            message = "is merciless (12)!!";
            icon = "kill12";
        }
        else if argument0==15 {
            action = "is unstoppable (15)!!!";
icon = "kill15";
        }
        else if argument0==20 {
            action = "is GODLIKE (20)!!!";
            icon = "kill20";
        }
        else if argument0==25 {
            action = "is a 1337 |-|4><0|2 (25)!!!!";
icon = "kill25";
        }
        else if argument0==30 {
            action = "should stop playing this game (30)!!!!";
            icon = "kill30";
        }
else exit;
       
        if icon == "kill3" { sprite = Streak3S;
        } else if icon == "kill6" { sprite = Streak6S;
        } else if icon == "kill9" { sprite = Streak9S;
        } else if icon == "kill12" { sprite = Streak12S;
        } else if icon == "kill15" { sprite = Streak15S;
        } else if icon == "kill20" { sprite = Streak20S;
        } else if icon == "kill25" { sprite = Streak25S;
        } else if icon == "kill30" { sprite = Streak30S;
        }
       
        with (KillLog) {
            map = ds_map_create();
            ds_map_add(map, "name1", name);
            ds_map_add(map, "team1", argument1);
            ds_map_add(map, "weapon", sprite);
            ds_map_add(map, "string", message);
            ds_map_add(map, "name2", action);
            ds_map_add(map, "team2", argument1);
            ds_map_add(map, "inthis", argument3);
                       
            ds_list_add(kills, map);
           
            if (ds_list_size(kills) > 5) {
                ds_map_destroy(ds_list_find_value(kills, 0));
                ds_list_delete(kills, 0);
            }
           
            alarm[0] = 30*5;
        }
playsound(view_xview[0]+400,view_yview[0]+300,NoticeSnd);
exit;


I don't think the resetTimer (or KSSwitch as I've named it here) is gonna be the solution but I can't think of what other checks I can do. Oddly enough the frankenplugin didn't run into this problem...

[Lorgan]

Pretty sure the kksswitch is useless atm but that doesn't really matter.

You did
   if (player.stats[KILLS] > currentStreak && player.stats[KILLS] - currentStreak != killStreak) {
      killStreak = player.stats[KILLS] - currentStreak;
   }
   if (global.isHost) {
   }

instead of


   if (player.stats[KILLS] > currentStreak && player.stats[KILLS] - currentStreak != killStreak) {
      killStreak = player.stats[KILLS] - currentStreak;
      if (global.isHost) {
      }
   }

[ZaSpai]

Yeah that unnested global.isHost wasn't something I should've changed >.>

anyway I think the killstreak bit now works with the logs appearing fine to me at least for a client racking up the killstreak (shouldn't matter though since I added loopback=true now). Also added the annoying >=30 condition for 'should stop playing this game!' message

(added zip; I don't want this added to SSP review or w/e ajf does since it's not yet got the RTD function it needs)