Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Phantom Brave]

This plugin is now deprecated.

(click to show/hide)

Multistab is bugged and kills up to 4 people instead of the 2 that it's supposed to.

Code: (MultistabHotfix.gml) [Select]

//Serverside multistab hotfix - caps multistab kills at 2 instead of 4
//Will protect those two lads who don't deserve to die, but causes minor desync whenever it actually matters.
//Zlib license, (c) 2012 Wareya @ GG2/Steam
//Untested, but if there's an issue, it's with the arguments to object_event_*.

object_event_clear(StabMask,ev_collision,Character);
object_event_add(StabMask,ev_collision,Character,"
    if(other.id != ownerPlayer.object and other.team != team  && other.hp > 0 && other.ubered == 0)
    {
        if(!collision_line(x,y-12,other.x,other.y,Obstacle,true,true)) and (!collision_line(x,y-12,other.x,other.y,TeamGate,true,true) and (!collision_line(x,y-12,other.x,other.y,BulletWall,true,true)))
        {
            other.hp -= hitDamage;
            other.timeUnscathed = 0;
            if (other.lastDamageDealer != ownerPlayer && other.lastDamageDealer != other.player)
            {
                other.secondToLastDamageDealer = other.lastDamageDealer;
                other.alarm[4] = other.alarm[3]
            }
            other.alarm[3] = ASSIST_TIME;
            other.lastDamageDealer = ownerPlayer;
            if sign(other.image_xscale) == sign(image_xscale)
                other.lastDamageSource = WEAPON_BACKSTAB;
            else
                other.lastDamageSource = WEAPON_KNIFE;
            var blood;
            if(global.gibLevel > 0)
            {
                repeat(70)
                {
                    blood = instance_create(x,y,Blood);
                    blood.direction = direction-180;
                }
            }
           
            //This is the relevant code. The old block here was a broken algorithm.
            numKills += 1;
            if numKills >= maxKills
                instance_destroy();
        }
        else
            alarm[0] = 1;
    }
");

object_event_clear(StabMask,ev_collision,Sentry);
object_event_add(StabMask,ev_collision,Sentry,"
    if(other.team != team)
    {
        if(!collision_line(x,y-12,other.x,other.y,Obstacle,true,true)) and (!collision_line(x,y-12,other.x,other.y,TeamGate,true,true) and (!collision_line(x,y-12,other.x,other.y,BulletWall,true,true)))
        {
            other.hp -= hitDamage;
            other.lastDamageDealer = ownerPlayer;
            other.lastDamageSource = weapon;

            //This is the relevant code. The old block here was a broken algorithm.
            numKills += 1;
            if numKills >= maxKills
                instance_destroy();
        }
        else
            alarm[0] = 1;
    }
");Version: 2.4.3, 2.4.4, any newer versions until multistab is fixed
Conflicts: ANYTHING that rewrites stab collision with characters

[Phantom Brave]

Bump for attention.

[Tornadoblitz]

But we love stabbing 4 people at the same time while they rage about infiltrator being OP!^{[citation needed]}

[Catman]

I'm liking Sani's new way of editing messages.

Anyway, I think stabbing should never allow you to kill more than two people at once and this isn't a bad idea just as long as we can still take down engineers who stand too close to their sentries as someone had said in that other thread.

[BTW I am Infiltrator]

How minor of a desync, and when does it actually matter?

[Phantom Brave]

It matters when:
A spy would kill >2 things in a single stab.
The desync:
Clients see more blood. Client side plugins that try predict deaths (which they shouldn't) will also get desynched. That's it.