The Gang Garrison 2 Forum

Gang Garrison Discussion => Announcements => Topic started by: ajf on January 27, 2014, 05:36:26 pm

Title: Gang Garrison 2.6.9
Post by: ajf on January 27, 2014, 05:36:26 pm
Previous
This
Next
2.6.8 (http://www.ganggarrison.com/forums/index.php?topic=34688.0)
2.6.9
2.7 (http://www.ganggarrison.com/forums/index.php?topic=35333.0)

v2.6.9: The interim update
- Incorporated Wareya's performance fix (also was in 2.6.8 hotfix)
- Upgraded to Faucet HTTP v1.0 - should fix menu crash/hang issues
- Friendlier server-sent plugin 404 message
- Changes to server-sent plugin networking API (may break existing plugins)
- Rewards for 2013 Halloween Mini-Haxxy

Download here (http://www.ganggarrison.com/download.php?file=1)
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 27, 2014, 05:55:26 pm
Regarding mini-haxxy rewards: this just adds the code for them. You won't have got them yet since I still need to talk to sani etc. about who gets what.

Second, this is called the *interim* update for a reason: It's an only barely improved 2.6.8. 2.7 will be a while yet. Unfortunately this means that this update fixes no bugs.

EDIT: The server-sent plugin changes are to allow loopback. See: http://www.ganggarrison.com/forums/index.php?topic=33509.0 (http://www.ganggarrison.com/forums/index.php?topic=33509.0)
Title: Re: Gang Garrison 2.6.9
Post by: ZaSpai on January 27, 2014, 08:43:24 pm
Code: [Select]
___________________________________________
ERROR in
action number 1
of Begin Step Event
for object Client:

In script ClientBeginStep:
In script doEventDestruction:
In script recordDestructionInLog:
Error in code at line 12:
                   killer += " + " + string_copy(argument2.name, 1, 20);
                                                           ^
at position 58: Unknown variable name

On Skele's, occurred during a map switch from drylands to ctf_fallbox, leading to deserialization error
Title: Re: Gang Garrison 2.6.9
Post by: notarctic on January 27, 2014, 10:01:24 pm
some lag issues here and there. joining players cause a brief drop in fps, and from what people keep saying, there are ping issues
Title: Re: Gang Garrison 2.6.9
Post by: Phantom Brave on January 28, 2014, 12:35:19 am
gg2 does not cause ping problems. distant servers and bad isps and routers and connections to routers cause ping problems.
Title: Re: Gang Garrison 2.6.9
Post by: Lorgan on January 28, 2014, 02:49:07 am
- Changes to server-sent plugin networking API (may break existing plugins)
What have you done ;_;
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 28, 2014, 03:02:29 am
Code: [Select]
___________________________________________
ERROR in
action number 1
of Begin Step Event
for object Client:

In script ClientBeginStep:
In script doEventDestruction:
In script recordDestructionInLog:
Error in code at line 12:
                   killer += " + " + string_copy(argument2.name, 1, 20);
                                                           ^
at position 58: Unknown variable name

On Skele's, occurred during a map switch from drylands to ctf_fallbox, leading to deserialization error
I'm 99% sure this version didn't touch that code.

- Changes to server-sent plugin networking API (may break existing plugins)
What have you done ;_;
Made your life easier :P
Title: Re: Gang Garrison 2.6.9
Post by: Intel Guard on January 28, 2014, 09:24:53 am
Aren't you a developer

It's still a bug so it should be addressed, especially if its an older bug
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 28, 2014, 09:46:50 am
Aren't you a developer

It's still a bug so it should be addressed, especially if its an older bug
I realise, it's just (luckily) not something introduced by this update.
Title: Re: Gang Garrison 2.6.9
Post by: BoltStorm on January 28, 2014, 12:32:27 pm
Ajf something in the update(maybe teh hotfix) fixed the bluescreen problem on my laptop. i just played for a while on Imps server no blu screen AT ALL!!!!!! (Only massive lag on the server)

went to andreyys after the post and some greenlighting and it happend again, well back to halomod i guess if that is still getting updated.
Title: Re: Gang Garrison 2.6.9
Post by: Rumrusher on January 28, 2014, 09:17:35 pm
hmm so is sentries and sniper fire crossing through gate doors at the start of A/D matches a feature in this patch?
Title: Re: Gang Garrison 2.6.9
Post by: Conan on January 28, 2014, 09:30:48 pm
gg2 does not cause ping problems. distant servers and bad isps and routers and connections to routers cause ping problems.
its hard to attribute the cause to that when servers that one never lagged on before suddenly start lagging like shit after the update, regardless of people joining/leaving.

ex: skele's itemserver; afaik he didn't change anything from his server beyond updating gg2, and suddenly the very-playable server i frequented before the update (with all mods downloaded ofc) becomes laggy as shit.
Title: Re: Gang Garrison 2.6.9
Post by: Phantom Brave on January 28, 2014, 10:12:00 pm
hmm so is sentries and sniper fire crossing through gate doors at the start of A/D matches a feature in this patch?
lol looks like ajf accidentally merged something he wasn't supposed to
or the git version he started on was unstable
Title: Re: Gang Garrison 2.6.9
Post by: notarctic on January 28, 2014, 10:19:58 pm
hmm so is sentries and sniper fire crossing through gate doors at the start of A/D matches a feature in this patch?
lol looks like ajf accidentally merged something he wasn't supposed to
or the git version he started on was unstable
that bug was present in 2.6.8 too.
Quote
Second, this is called the *interim* update for a reason: It's an only barely improved 2.6.8. 2.7 will be a while yet. Unfortunately this means that this update fixes no bugs.
Title: Re: Gang Garrison 2.6.9
Post by: Phantom Brave on January 28, 2014, 10:21:45 pm
oh I forgot it was already a bug in release
Title: Re: Gang Garrison 2.6.9
Post by: Skeletonwitch on January 28, 2014, 11:37:00 pm
gg2 does not cause ping problems. distant servers and bad isps and routers and connections to routers cause ping problems.
its hard to attribute the cause to that when servers that one never lagged on before suddenly start lagging like shit after the update, regardless of people joining/leaving.

ex: skele's itemserver; afaik he didn't change anything from his server beyond updating gg2, and suddenly the very-playable server i frequented before the update (with all mods downloaded ofc) becomes laggy as shit.

Confirmed, I have not changed anything about my server.  I have ran speedtests, scans, and restarted router to check for other problems.  Some people are having none, others are lagging considerably.
Title: Re: Gang Garrison 2.6.9
Post by: ZaSpai on January 28, 2014, 11:48:31 pm
gg2 does not cause ping problems. distant servers and bad isps and routers and connections to routers cause ping problems.
its hard to attribute the cause to that when servers that one never lagged on before suddenly start lagging like shit after the update, regardless of people joining/leaving.

ex: skele's itemserver; afaik he didn't change anything from his server beyond updating gg2, and suddenly the very-playable server i frequented before the update (with all mods downloaded ofc) becomes laggy as shit.

Confirmed, I have not changed anything about my server.  I have ran speedtests, scans, and restarted router to check for other problems.  Some people are having none, others are lagging considerably.

To add to this, it has been lagging at player numbers that didn't cause lag before (like 8, when in 2.6.8 this wouldn't happen until around 10-12. Oddly sometimes more players runs normally... :z9: )
Title: Re: Gang Garrison 2.6.9
Post by: notarctic on January 29, 2014, 02:00:10 am
would it possibly be an issue with faucet http?
Title: Re: Gang Garrison 2.6.9
Post by: Catman on January 29, 2014, 05:36:54 am
Updater isn't doing anything
Title: Re: Gang Garrison 2.6.9
Post by: t~ on January 29, 2014, 09:18:04 am
Is checking for server vacancies before downloading server sent plugins in this update?
Title: Re: Gang Garrison 2.6.9
Post by: Danikah on January 29, 2014, 10:08:34 am
Is checking for server vacancies before downloading server sent plugins in this update?
Chances are, no.
This update is essentially a collection of performance and connection fixes you could have downloaded separately on the forums before, from what I can gather.
A true update like that might be the 2.7.
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 29, 2014, 02:54:59 pm
Updater isn't doing anything
I had that and assumed it was WINE's fault. Maybe not, will look into it.
Title: Re: Gang Garrison 2.6.9
Post by: 2D on January 29, 2014, 03:32:09 pm
Tons of lag with the new update.
Pyro and  :quote:  :curly: can push people through some doors.
Title: Re: Gang Garrison 2.6.9
Post by: Sparky on January 29, 2014, 03:37:49 pm
Tons of lag with the new update.
Pyro and  :quote:  :curly: can push people through some doors.
Haha on pubs people troll doing that‚ its funny :D
Title: Re: Gang Garrison 2.6.9
Post by: notarctic on January 29, 2014, 05:19:47 pm
Tons of lag with the new update.
Pyro and  :quote:  :curly: can push people through some doors.
either its a bug that existed last update, or its a flaw in map design
Title: Re: Gang Garrison 2.6.9
Post by: Conan on January 29, 2014, 06:27:21 pm
Is checking for server vacancies before downloading server sent plugins in this update?
confirmed no

funnily enough this update pushed out more bugs than fixes, in terms of what most users notice.
Title: Re: Gang Garrison 2.6.9
Post by: Phantom Brave on January 29, 2014, 06:45:52 pm
explain how the codebase barely changed especially in regards to your supposed new bugs then
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 29, 2014, 07:05:48 pm
So, let me re-iterate the changes:

* Server plugin API changes (won't cause bugs but might break plugins)
* New haxxy rewards (won't change anything)
* New faucet HTTP (won't affect gameplay at all)
* New server-sent plugin 404 message (won't affect gameplay at all)


(http://memney.com/files/2013/04/condescending-willy-wonka-meme-template.jpg)
Please, tell me about these new bugs and lag.
Title: Re: Gang Garrison 2.6.9
Post by: BassMakesPaste on January 29, 2014, 07:08:12 pm
My ping is slightly higher on every server since the update. Dunno if that's what they're talking about, but maybe.
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 29, 2014, 07:09:52 pm
My ping is slightly higher on every server since the update.
FTFY
Title: Re: Gang Garrison 2.6.9
Post by: BassMakesPaste on January 29, 2014, 07:27:57 pm
My ping is slightly higher on every server since the update.
FTFY
As soon as you posted that, my ping dropped.

What sorcery is this

Ajf stop breaking my internet
Title: Re: Gang Garrison 2.6.9
Post by: Conan on January 29, 2014, 08:45:58 pm
explain how the codebase barely changed especially in regards to your supposed new bugs then
i meant user-wise perceived changes, not actual changes. not trying to attack you guys for not doing your job right.

take your time the game somehow fixed itself so its playable now, instead of debilitating lag.
Title: Re: Gang Garrison 2.6.9
Post by: notarctic on January 29, 2014, 09:36:16 pm
would it possibly be a memory leak in faucet http?
Title: Re: Gang Garrison 2.6.9
Post by: Intel Guard on January 30, 2014, 12:25:26 am
Is checking for server vacancies before downloading server sent plugins in this update?
confirmed no

funnily enough this update pushed out more bugs than fixes, in terms of what most users notice.
not really, this happens every time. gg2 is just not a very well optimized game.
Title: Re: Gang Garrison 2.6.9
Post by: Catman on January 30, 2014, 03:25:18 am
Clearly something is wrong when my updater doesn't do anything, even with my very capable download speed.

Like what the hell, I don't understand how that is the thing that doesn't work when nothing is supposed to be broken.
Title: Re: Gang Garrison 2.6.9
Post by: BoltStorm on January 30, 2014, 06:33:50 am
when i played yesterday on BTWs server with the update a strange thing occurded or should i say dint:
i played on that server for 1 and a half hour without a bluescreen at... but if i want to play at andreyyys i get the bluscreen.

im starting to feel that my crappy laptop isnt the only one to blame for that
Title: Re: Gang Garrison 2.6.9
Post by: Intel Guard on January 30, 2014, 07:06:28 am
Im pretty sure it is. GG2 eats cpu like a motherfucker on lower end stuff
Title: Re: Gang Garrison 2.6.9
Post by: andreyyy on January 30, 2014, 08:38:19 am
lol my ping is even better since the update (could be a fluke of course...)
btw am I the only one who has a fucking gamer notebook and plays gg2?
Title: Re: Gang Garrison 2.6.9
Post by: Danikah on January 30, 2014, 08:38:35 am
Can we actually take a look into the code instead of shooting down bugreporters with "we didn't do anything in that area" responses?
It'll help, see Valve, where they can fuck up an Engineer building by fixing a knife animation bug. Made up example, though something similar to that did happen once.
Title: Re: Gang Garrison 2.6.9
Post by: Phantom Brave on January 30, 2014, 12:46:09 pm
Can we actually take a look into the code instead of shooting down bugreporters with "we didn't do anything in that area" responses?
It'll help, see Valve, where they can fuck up an Engineer building by fixing a knife animation bug. Made up example, though something similar to that did happen once.
except ajf literally made this update in like 30 minutes by essentially copy and pasting specific lines of code from dev versions of gg2
the ONLY REMOTELY PLAUSIBLE cause of lag is a memory leak and those are actually rather difficult to cause in game maker and when they DO happen they don't affect performance until you've been playing for QUITE a long time, even if you're already maxing out a CPU core, because memory leaks only bottleneck performance when memory usage gets way too high
Title: Re: Gang Garrison 2.6.9
Post by: Danikah on January 30, 2014, 12:57:16 pm
Whatever, I guess.

Though I think it was pointless to push out an update as small as this. We would have been fine with 2.6.8 for some more time, I believe.
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 30, 2014, 02:55:50 pm
Can we actually take a look into the code instead of shooting down bugreporters with "we didn't do anything in that area" responses?
It'll help, see Valve, where they can fuck up an Engineer building by fixing a knife animation bug. Made up example, though something similar to that did happen once.
except ajf literally made this update in like 30 minutes by essentially copy and pasting specific lines of code from dev versions of gg2
the ONLY REMOTELY PLAUSIBLE cause of lag is a memory leak and those are actually rather difficult to cause in game maker and when they DO happen they don't affect performance until you've been playing for QUITE a long time, even if you're already maxing out a CPU core, because memory leaks only bottleneck performance when memory usage gets way too high
I didn't even copy-and-paste, it was just git merges aside from your hotfix.

Whatever, I guess.

Though I think it was pointless to push out an update as small as this. We would have been fine with 2.6.8 for some more time, I believe.
Right, but I needed to make this so I could push out Mini-Haxxy rewards.
Title: Re: Gang Garrison 2.6.9
Post by: notarctic on January 30, 2014, 05:43:32 pm
Can we actually take a look into the code instead of shooting down bugreporters
be my guest
https://github.com/TazeTSchnitzel/Gang-Garrison-2/tree/2.6.9Staging
check the last few commits
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 30, 2014, 06:03:59 pm
Can we actually take a look into the code instead of shooting down bugreporters
be my guest
https://github.com/TazeTSchnitzel/Gang-Garrison-2/tree/2.6.9Staging
check the last few commits
The last few commits won't be representative, as some stuff merged might've been made prior to 2.6.8.

Instead, look at the comparison: https://github.com/TazeTSchnitzel/Gang-Garrison-2/compare/V2.6.8...V2.6.9

Title: Re: Gang Garrison 2.6.9
Post by: Derpduck on January 31, 2014, 03:02:05 pm
While this isn't new, I think it is something that should be reported.
Code: [Select]
    var map, i;
    if (global.shuffleRotation) {
        ds_list_shuffle(global.map_rotation);
        map = ds_list_find_value(global.map_rotation, 0);
        // "Shuffle, don't make arena map first" chosen
        if (global.shuffleRotation == 1) {
            // if first map is arena
            if (string_copy(map, 0, 6) == 'arena_') {
                // try to find something else
                for (i = 0; i < ds_list_size(global.map_rotation); i += 1) {
                    map = ds_list_find_value(global.map_rotation, i);
                    // swap with first map
                    if (string_copy(map, 0, 6) != 'arena_') {
                        ds_list_replace(global.map_rotation, i, ds_list_find_value(global.map_rotation, 0));
                        ds_list_replace(global.map_rotation, 0, map);
                    }
                }
            }
        }
    }
This means that arena maps that do not have an underscore after the name are not affected by this checking.
Title: Re: Gang Garrison 2.6.9
Post by: ajf on January 31, 2014, 03:06:10 pm
This means that arena maps that do not have an underscore after the name are not affected by this checking.
There aren't many of them though, so long as people name maps properly.

It's a bit of a hack anyhow, since this doesn't actually detect the map type, it just looks at the name. I think it's the best I can do here, though.
Title: Re: Gang Garrison 2.6.9
Post by: Derpduck on January 31, 2014, 03:08:42 pm
Well, you could just make it not check for underscores. Even if there aren't many of these maps they do still exist and people do host them.