The Gang Garrison 2 Forum

Gang Garrison Discussion => Announcements => Topic started by: Phantom Brave on October 12, 2013, 10:51:00 am

Title: 2.6.8 Performance Hotfix
Post by: Phantom Brave on October 12, 2013, 10:51:00 am
People with old CPUs have been experiencing performance problems since the recent update binge, even last one, which improved performance dramatically.

This is because the movement solver was changed (the code for figuring out character movement when the run into things) to avoid glitching out when you hit doors at the same time as you walk up stairs or hit the ground). I'm not going to bother to explain the technical details. The original overhaul was extremely buggy, and had performance problems, so I decided to go with the obvious solution (other devs suggested against it in the past) and use the old collision system in the new way. Basically, putting the code that GG2 used to move characters around forever, in the place where I had put the overhauled code, and tweaking whatever minor things about it were necessary to make it work.

This hotfix makes the current system only override GM's built in movement only when it needs to instead of every single frame.

Download: https://dl.dropboxusercontent.com/u/1811521/Gang%20Garrison%202%202.6.8%20Performance%20Hotfix.exe

Because this is a hotfix meant to be compatible with the current release, I can't do things like fix setupgates. We're gathering up fixes like that for a bigger bugfix release to avoid shotgunning one after another again.
Title: Re: 2.6.8 Performance Hotfix
Post by: Friendly Holocaust on October 12, 2013, 02:26:33 pm
Good job, it works.
Title: Re: 2.6.8 Performance Hotfix
Post by: notarctic on October 13, 2013, 01:40:18 am
can you upload the source?
Title: Re: 2.6.8 Performance Hotfix
Post by: Phantom Brave on October 13, 2013, 08:31:03 am
11:23 AM - Rabbit: replace line 5 of Character Step with
11:23 AM - Rabbit: if(!place_free(x+hspeed, y+vspeed))
    characterHitObstacle();
11:23 AM - Rabbit: these two
Title: Re: 2.6.8 Performance Hotfix
Post by: notarctic on October 13, 2013, 12:54:46 pm
Quote from: Phantom Brave on October 13, 2013, 08:31:03 am
11:23 AM - Rabbit: replace line 5 of Character Step with
11:23 AM - Rabbit: if(!place_free(x+hspeed, y+vspeed))
    characterHitObstacle();
11:23 AM - Rabbit: these two
oh cool
Title: Re: 2.6.8 Performance Hotfix
Post by: notarctic on October 13, 2013, 03:55:36 pm
wait...so why isnt this just a simple plugin?

Code: [Select]
object_event_clear(Character,ev_step,ev_step_normal);
object_event_add(Character,ev_step,ev_step_normal,"
    if(!place_free(x+hspeed, y+vspeed))
    characterHitObstacle()
");
EDIT: yep i derped and read line 5 as 5 lines
Title: Re: 2.6.8 Performance Hotfix
Post by: Phantom Brave on October 13, 2013, 03:58:49 pm
1) That code doesn't work.
2) Why would I make something performance critical a plugin. :U
Title: Re: 2.6.8 Performance Hotfix
Post by: 2D on October 14, 2013, 12:19:04 pm
Quote from: Phantom Brave on October 13, 2013, 03:58:49 pm
1) That code doesn't work.
2) Why would I make something performance critical a plugin. :U

It works fine for me. I haven't had much problem with stairs, but player platforms still hold me down as Pyro and Quote.
Title: Re: 2.6.8 Performance Hotfix
Post by: Phantom Brave on October 14, 2013, 12:21:45 pm
~*~THAT MEANS IT DOESN'T WORK, 2.6.8 ALREADY FIXED THAT BUG AND THIS PLUGIN PROBABLY REINTRODUCES IT~*~
Title: Re: 2.6.8 Performance Hotfix
Post by: 2D on October 18, 2013, 08:11:36 am
Quote from: Phantom Brave on October 14, 2013, 12:21:45 pm
~*~THAT MEANS IT DOESN'T WORK, 2.6.8 ALREADY FIXED THAT BUG AND THIS PLUGIN PROBABLY REINTRODUCES IT~*~

(click to show/hide)

[/quote]
In addition, Quotes will fly strait out of RED spawn on the same map if the right key isn't held down.
Title: Re: 2.6.8 Performance Hotfix
Post by: Phantom Brave on October 18, 2013, 11:34:34 am
That's a different bug than the one the plugin reintroduces. This is a bug caused by undocumented GM behavior that affected the old collision code but not the perfect stuff. I figured out the solution already but it's not gamebreaking and it's caused by bad spawns which literally put the characters inside of the map.
Title: Re: 2.6.8 Performance Hotfix
Post by: 2D on November 01, 2013, 10:57:12 am
Quote from: Phantom Brave on October 18, 2013, 11:34:34 am
That's a different bug than the one the plugin reintroduces. This is a bug caused by undocumented GM behavior that affected the old collision code but not the perfect stuff. I figured out the solution already but it's not gamebreaking and it's caused by bad spawns which literally put the characters inside of the map.

How is it going to be fixed? It only effects   :quote: /  :curly: on koth_corinth
Title: Re: 2.6.8 Performance Hotfix
Post by: Phantom Brave on November 01, 2013, 11:00:00 am
I already fixed it. In beta.
Title: Re: 2.6.8 Performance Hotfix
Post by: 2D on November 01, 2013, 11:55:45 am
Quote from: Phantom Brave on November 01, 2013, 11:00:00 am
I already fixed it. In beta.
Great! Thanks.
Title: Re: 2.6.8 Performance Hotfix
Post by: \esc144aAroundTheWorld\esca on November 01, 2013, 11:57:24 am
>2D pretending to be Oktoberfest
Title: Re: 2.6.8 Performance Hotfix
Post by: 2D on November 01, 2013, 12:04:21 pm
Quote from: Splat on November 01, 2013, 11:57:24 am
>2D pretending to be Oktoberfest

Lol wut?
Title: Re: 2.6.8 Performance Hotfix
Post by: 64 on November 01, 2013, 12:57:46 pm
I dowloaded it, barely lagging now, thank you.
Title: Re: 2.6.8 Performance Hotfix
Post by: BoltStorm on November 13, 2013, 10:53:39 am
thank you very much now i can play regular gg2 again.
Title: Re: 2.6.8 Performance Hotfix
Post by: 21Dan on November 14, 2013, 04:02:33 am
Told you.  ;)
Title: Re: 2.6.8 Performance Hotfix
Post by: boi on November 14, 2013, 07:13:17 am
This doesn't seem to be fixing my mouse lag problem...

Oh well, maybe sometime soon in the future.
Title: Re: 2.6.8 Performance Hotfix
Post by: BoltStorm on November 14, 2013, 08:05:35 am
Quote from: 21Dan on November 14, 2013, 04:02:33 am
Told you.  ;)
yea well about that: it dint work i spoke a bit to soon and got blu screen instantly
Title: Re: 2.6.8 Performance Hotfix
Post by: Intel Guard on November 14, 2013, 08:14:30 am
Quote from: boi on November 14, 2013, 07:13:17 am
This doesn't seem to be fixing my mouse lag problem...

Oh well, maybe sometime soon in the future.
end stij.exe in taskmanager

get ccleaner and delete IBUpdaterService from the registry, uninstall anything related to IBUpdaterService
Title: Re: 2.6.8 Performance Hotfix
Post by: boi on November 14, 2013, 08:17:42 pm
Quote from: Intel Guard on November 14, 2013, 08:14:30 am
Quote from: boi on November 14, 2013, 07:13:17 am
This doesn't seem to be fixing my mouse lag problem...

Oh well, maybe sometime soon in the future.
end stij.exe in taskmanager

get ccleaner and delete IBUpdaterService from the registry, uninstall anything related to IBUpdaterService
I'll try to do that when I have the time.
Title: Re: 2.6.8 Performance Hotfix
Post by: boi on November 16, 2013, 12:49:33 am
Apparently the problem is stij.exe. But every time I end it, it comes back a few seconds later.

Can't find the IBU thing in CCleaner, though.

EDIT: I found and deleted the IBU thing in Add/Remove Programs in the task manager. And apparently that's what's causing the mouse lag. Thanks Intel.
Title: Re: 2.6.8 Performance Hotfix
Post by: Intel Guard on November 16, 2013, 09:59:26 am
No problem.