The Gang Garrison 2 Forum

Gang Garrison Discussion => Announcements => Topic started by: ajf on October 02, 2013, 11:16:50 am

Title: Gang Garrison 2.6.6
Post by: ajf on October 02, 2013, 11:16:50 am
Previous
This
Next
2.6.5 (http://www.ganggarrison.com/forums/index.php?topic=34672.0)
2.6.6
2.6.7 (http://www.ganggarrison.com/forums/index.php?topic=34679.0)

v2.6.6: The hackfix3 update
- Fixed bug with multi-client limit capping player limit to client limit
- Fixed bug with multi-client limit where message byte not sent

Download here (http://www.ganggarrison.com/download.php?file=1)
Title: Re: Gang Garrison 2.6.6
Post by: ajf on October 02, 2013, 11:27:57 am
Massive apologies on my part for letting this happen. While I don't think you can blame me for not spotting that bug, me rushing the release out to try and get it over with was obviously a mistake. A tiny playtest would have found both bugs.

What was the bug this time? Er, basically:

16:57 - Croissant: oh
16:57 - Croissant: so
16:57 - Croissant: I found the bug
16:57 - Croissant: with multiclient
16:58 - Croissant: ahahahahaahhahaahaha
16:58 - Croissant: this is amazing
16:58 - Croissant: var socket, joiningPlayer, totalClientNumber;
socket = socket_accept(global.tcpListener);
16:58 - Croissant: var ip;
    ip = socket_remote_ip(socket);
16:58 - Croissant: so far so good right
16:58 - Croissant: well
16:58 - Croissant: with (Player)
        {
            if (socket_remote_ip(socket) == ip)
                clientCount += 1;
16:58 - Croissant: vars override instance variables
16:58 - Croissant: so that means
16:58 - Croissant: if (ip == ip)
16:58 - Croissant: so
16:58 - Croissant: if (1)
16:58 - Croissant: oops

yup
Title: Re: Gang Garrison 2.6.6
Post by: Port on October 02, 2013, 03:10:11 pm
Is it just me or is there a massive mess with the UUIDs/versions right now?
This is all from a download of the latest version made after this topic.

Gang Garrison 2.gmk constants:

VERSION = 26600
GAME_VERSION_STRING = "v2.6.6"


Gang Garrison 2.exe only shows 2.6.5 servers as current - 2.6.6 is grayed out.
Additionally, the GitHub repo is still at 2.6.3.

  <constant name="VERSION" value="26300"/>
  <constant name="GAME_VERSION_STRING" value="&quot;v2.6.3&quot;"/>
Title: Re: Gang Garrison 2.6.6
Post by: Phantom Brave on October 02, 2013, 03:33:49 pm
2.6.6 is not grayed out here.

github repo is just out of date.
Title: Re: Gang Garrison 2.6.6
Post by: MedO on October 02, 2013, 03:50:23 pm
I just didn't pull ajf's changes into my repo yet, they are up on his fork.

As for the wrong version being greyed out, that soulds pretty unlikely. The same constant is used on both the client and the server, so it's not as if you could forget to update just one side.
Title: Re: Gang Garrison 2.6.6
Post by: NAGN on October 02, 2013, 03:51:06 pm
I was unable to replicate the bug using the version downloaded from the frontpage, the gmk is compatible with 2.6.5 and 2.6.6